Show answered questions in the thread timeline by colonelpanic8 · Pull Request #4506 · pingdotgg/t3code

colonelpanic8 · 2026-07-25T08:30:09Z

What Changed

A clarifying-question round trip (Claude's AskUserQuestion, and the same
user-input.* events from the other providers) now renders as a single Q&A card
in the thread timeline: the question header, the question, and the option(s) the
user picked — or their free-text answer. The alternatives stay one click away
behind "Show options".

deriveWorkLogEntries merges user-input.requested with its
user-input.resolved into one entry (entry.userInput), resolving each answer
against the question's options so a picked label and an "Other" answer render
differently. A resolution whose request has scrolled out of the activity window
still shows its answer.
Q&A entries get their own timeline row, so neither the work-group collapse nor
the settled-turn fold hides them — the exchange records a decision, so it stays
readable in history.
The duplicate AskUserQuestion tool rows are dropped, the same way
ExitPlanMode rows are already suppressed.

Why

The answers were already persisted — user-input.resolved carries
{"answers": {"<question>": "<label>"}} — but nothing rendered them. The
timeline showed two contentless rows, User input requested and
User input submitted, neither expandable, plus a Tool call row whose only
content was truncated request JSON (AskUserQuestion: {"questions":[{"header"...).
Both sat inside the work-group collapse (MAX_VISIBLE_WORK_LOG_ENTRIES = 1) and
the turn fold, so in practice a finished thread showed no trace of the question
or the answer at all.

That is a real gap in the transcript: the interactive prompt lives in the
composer and disappears once answered, so the timeline is the only lasting record
of what the agent asked and what the user decided.

UI Changes

Same seeded thread in every shot: two questions (one single-select answered with
free text, one multi-select), plus the AskUserQuestion tool rows Claude emits
alongside the events.

Before — settled turn, as you first see it. The exchange is entirely absent:

Before — after expanding both the turn fold and the work group. Two empty
rows and a JSON dump; the answers appear nowhere:

After — settled turn, no expansion needed:

After — "Show options" reveals the alternatives, with the picked ones highlighted:

After — turn fold expanded: the card sits inline where the question was
asked, surrounding tool calls still collapse as before, and the raw
AskUserQuestion row is gone:

Scope note: apps/mobile/src/lib/threadActivity.ts carries its own copy of this
derivation and has the same gap. Left out to keep this PR focused on one surface.

Validation

vp test run src/session-logic.test.ts                              # 66 passed (7 new)
vp test run src/components/chat/MessagesTimeline.logic.test.ts     # 30 passed (2 new)
vp test run src/components/chat/MessagesTimeline.test.tsx          # 16 passed (2 new)
tsgo --noEmit                          # apps/web, clean
vp lint --report-unused-disable-directives <changed files>         # clean
vp fmt <changed files>

Plus an integrated pass in a browser against an isolated dev environment
(vp run dev --home-dir …) with the seeded thread above — that is where the
screenshots come from.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes — n/a, no motion

Note

Low Risk
Web-only chat timeline and session-logic presentation changes with broad test coverage; no auth, API, or data-persistence changes.

Overview
Clarifying-question exchanges now show up as persistent Q&A cards in the thread timeline instead of disappearing into collapsed work logs and settled-turn folds.

deriveWorkLogEntries merges user-input.requested / user-input.resolved into one work entry with structured userInput (questions, selected options, free-text answers), filters duplicate AskUserQuestion tool rows, and handles edge cases like orphaned resolutions and OpenCode’s comma-joined multi-select strings.

Timeline derivation adds a dedicated user-input row so these entries are not grouped with tool work or hidden by turn folding. MessagesTimeline renders the card with question text, the chosen answer (or “Awaiting your answer”), and an optional “Show options” toggle for alternatives.

^{Reviewed by Cursor Bugbot for commit fd30c91. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Show answered clarifying questions as Q&A cards in the chat timeline

Adds a new 'user-input' row type to the timeline that renders clarifying-question exchanges as a styled Q&A card showing questions, selected answers, and an optional toggle for unchosen options.
Updates deriveWorkLogEntries in session-logic.ts to merge user-input.requested and user-input.resolved activities into a single structured entry, dropping duplicate AskUserQuestion tool rows.
Updates deriveTurnFolds to keep clarifying-question entries visible even when their turn is collapsed.
Unanswered questions show 'Awaiting your answer'; answered questions display the selected option labels and any free-text custom answer.

^{Macroscope summarized fd30c91.}

coderabbitai · 2026-07-25T08:30:16Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22e1c4c6-d51c-4224-b3d3-68bc4f537e39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-25T08:34:23Z

Approvability

Verdict: Needs human review

This PR introduces a new feature with new UI components (UserInputTimelineRow, UserInputAnswer), new data structures, and significant logic for displaying Q&A exchanges in the thread timeline. New user-facing features of this scope warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}

#44) Source: pingdotgg#4506 Source SHA: f7eaa00 Imported unchanged as one candidate provenance commit.

…meline) # Conflicts: # apps/web/src/components/chat/MessagesTimeline.logic.test.ts # apps/web/src/components/chat/MessagesTimeline.logic.ts

A clarifying-question round trip left no readable trace in the thread. The `user-input.requested` / `user-input.resolved` activities carry the questions and the answers in their payloads, but the timeline rendered them as two contentless rows ("User input requested" / "User input submitted"), and the `AskUserQuestion` tool row beside them showed only truncated request JSON. Both were also collapsed behind the work-group toggle and the turn fold, so scrolling back gave no record of what was asked or what was chosen. Merge the request and its resolution into one Q&A entry, render it as a card with the question header, the question, and the picked option(s) or free-text answer, and keep it out of the work-group collapse and the turn fold. The alternatives stay one click away behind "Show options". The duplicate `AskUserQuestion` tool rows are dropped, mirroring how `ExitPlanMode` rows are already suppressed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

OpenCode joins a multi-select reply into one ", "-separated string. Splitting on every comma corrupted two cases: a free-text answer that happens to contain a comma was chopped into fragments, and an option label containing a comma ("Small, safe change") never matched again. Consume the value label by label, longest first, and fall back to treating it as free text when it is not a run of option labels. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit fd30c91. Configure here.}

cursor · 2026-07-27T11:22:05Z

+  }
+  // `tool.started` lands before any input streams, leaving only the detail prefix.
+  return asTrimmedString(payload?.detail)?.startsWith("AskUserQuestion:") === true;
+}


Tool row hidden without Q&A

Medium Severity

isUserInputToolActivity always drops AskUserQuestion tool rows, but a structured userInput card is only created when requestId is present and parseUserInputQuestions succeeds. When that fails, the timeline keeps only a contentless generic request row, so the question JSON that previously lived on the tool row is gone.

Additional Locations (1)

apps/web/src/session-logic.ts#L811-L829

^{Reviewed by Cursor Bugbot for commit fd30c91. Configure here.}

cursor · 2026-07-27T11:22:05Z

+            ...asked,
+            label: userInputWorkLogLabel(questions),
+            userInput: { ...asked.userInput, answered: true, questions },
+          };


Awaiting state ignores stale failures

Low Severity

deriveWorkLogEntries never clears or marks a clarifying-question card when provider.user-input.respond.failed reports a stale pending request. derivePendingUserInputs already drops that prompt, so the timeline can keep showing Awaiting your answer after the composer has moved on.

Additional Locations (1)

apps/web/src/session-logic.ts#L666-L673

^{Reviewed by Cursor Bugbot for commit fd30c91. Configure here.}

…meline) # Conflicts: # apps/web/src/components/chat/MessagesTimeline.logic.test.ts # apps/web/src/components/chat/MessagesTimeline.logic.ts

github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jul 25, 2026

cursor Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread apps/web/src/session-logic.ts

Comment thread apps/web/src/session-logic.ts

macroscopeapp Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread apps/web/src/session-logic.ts Outdated

cursor Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread apps/web/src/session-logic.ts Outdated

colonelpanic8 force-pushed the t3code/user-input-qna-timeline branch from cec9f42 to f7eaa00 Compare July 25, 2026 09:21

patroza mentioned this pull request Jul 25, 2026

feat(web): import answered question timeline (upstream #4506) patroza/t3code#44

Merged

patroza added a commit to patroza/t3code that referenced this pull request Jul 25, 2026

feat(web): import answered question timeline (upstream pingdotgg#4506) (

89585cb

#44) Source: pingdotgg#4506 Source SHA: f7eaa00 Imported unchanged as one candidate provenance commit.

patroza mentioned this pull request Jul 25, 2026

fix(web): reconcile fork timeline behavior with upstream questions patroza/t3code#46

Merged

colonelpanic8 and others added 3 commits July 27, 2026 03:26

fix(web): preserve user input answers in timeline

534cb76

colonelpanic8 force-pushed the t3code/user-input-qna-timeline branch from f7eaa00 to fd30c91 Compare July 27, 2026 11:14

cursor Bot reviewed Jul 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Show answered questions in the thread timeline#4506

Show answered questions in the thread timeline#4506
colonelpanic8 wants to merge 3 commits into
pingdotgg:mainfrom
colonelpanic8:t3code/user-input-qna-timeline

colonelpanic8 commented Jul 25, 2026 •

edited by cursor Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 25, 2026 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

Uh oh!

macroscopeapp Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Jul 27, 2026

Uh oh!

cursor Bot Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

colonelpanic8 commented Jul 25, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

UI Changes

Validation

Checklist

Show answered clarifying questions as Q&A cards in the chat timeline

Uh oh!

coderabbitai Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Uh oh!

macroscopeapp Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jul 27, 2026

Choose a reason for hiding this comment

Tool row hidden without Q&A

Uh oh!

cursor Bot Jul 27, 2026

Choose a reason for hiding this comment

Awaiting state ignores stale failures

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

colonelpanic8 commented Jul 25, 2026 •

edited by cursor Bot

Loading

coderabbitai Bot commented Jul 25, 2026 •

edited

Loading

macroscopeapp Bot commented Jul 25, 2026 •

edited

Loading